Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified my non-empty contributions to remove (hopefully) scala 2.13 … #921

Merged
merged 4 commits into from
May 29, 2022
Merged

modified my non-empty contributions to remove (hopefully) scala 2.13 … #921

merged 4 commits into from
May 29, 2022

Conversation

TimPigden
Copy link
Contributor

…dependency #836

@TimPigden TimPigden requested a review from a team as a code owner May 27, 2022 10:17
sideeffffect
sideeffffect reviewed May 27, 2022
View reviewed changes
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few places with commented code, otherwise looks good to me 👍

core/shared/src/main/scala/zio/prelude/NonEmptySortedSet.scala Outdated

/**
* The `CommutativeEither` instance for `NonEmptySortedSet`.
* todo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha - yes. I was working from the NonEmptySet as basis but wasn't sure about the whole invariant and equivalence stuff and whether it made sense for the sorted sets.
I still; don't know the answer to that

core/shared/src/main/scala/zio/prelude/NonEmptySortedSet.scala Outdated Show resolved Hide resolved
@TimPigden
Copy link
Contributor Author

Help - can someone tell me what the problem is now? It's talking about "expected fix". But I've no idea what's expected.

@sideeffffect
Copy link
Member

Run sbt fix and everything will be alright 😉

sideeffffect
sideeffffect reviewed May 27, 2022
View reviewed changes
Copy link
Member

@sideeffffect sideeffffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

@adamgfraser adamgfraser merged commit d38cadb into zio:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideeffffect sideeffffect sideeffffect left review comments

@regiskuckaertz regiskuckaertz regiskuckaertz left review comments

@adamgfraser adamgfraser adamgfraser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimPigden @sideeffffect @regiskuckaertz @adamgfraser